Skip to content

Models with incorrect tokenizer_class in tokenization_config.json tha…#44179

Merged
ArthurZucker merged 1 commit intomainfrom
bad_models
Feb 23, 2026
Merged

Models with incorrect tokenizer_class in tokenization_config.json tha…#44179
ArthurZucker merged 1 commit intomainfrom
bad_models

Conversation

@itazap
Copy link
Collaborator

@itazap itazap commented Feb 20, 2026

Models with incorrect tokenizer_class in tokenization_config.json that should use TokenziersBackend

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@itazap itazap requested a review from ArthurZucker February 20, 2026 14:13
@itazap
Copy link
Collaborator Author

itazap commented Feb 20, 2026

run-slow: auto, deepseek_vl, deepseek_vl_hybrid, jamba, janus, llava, llava_next, phi3, vipllava

@github-actions
Copy link
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/auto", "models/deepseek_vl", "models/deepseek_vl_hybrid", "models/jamba", "models/janus", "models/llava", "models/llava_next", "models/phi3", "models/vipllava"]
quantizations: []

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to have a super minimal list but yes otherwise

Comment on lines +349 to +350
"llava",
"llava_next",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these from the vllm ci as well?

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 02ec8936 workflow commit (merge commit)
PR 124dab3f branch commit (from PR)
main 32deb4c3 base commit (on main)

Model CI Report

7 new failed tests from this PR 😭

  • deepseek_vl:
    tests/models/deepseek_vl/test_modeling_deepseek_vl.py::DeepseekVLIntegrationTest::test_model_text_generation_batched (❌ ⟹ ❌)

  • deepseek_vl_hybrid:
    tests/models/deepseek_vl_hybrid/test_modeling_deepseek_vl_hybrid.py::DeepseekVLHybridIntegrationTest::test_model_text_generation_batched (❌ ⟹ ❌)

  • jamba:
    tests/models/jamba/test_modeling_jamba.py::JambaModelIntegrationTest::test_simple_batched_generate_with_padding (❌ ⟹ ❌)

  • janus:
    tests/models/janus/test_modeling_janus.py::JanusIntegrationTest::test_model_generate_images (❌ ⟹ ❌)
    tests/models/janus/test_modeling_janus.py::JanusIntegrationTest::test_model_text_generation_batched (❌ ⟹ ❌)

  • llava:
    tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_pixtral (❌ ⟹ ❌)
    tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_tokenizer_integration (❌ ⟹ ❌)

@itazap
Copy link
Collaborator Author

itazap commented Feb 20, 2026

@ArthurZucker ArthurZucker merged commit df1cd3a into main Feb 23, 2026
26 of 27 checks passed
@ArthurZucker ArthurZucker deleted the bad_models branch February 23, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants